From c457da5632e6bf73240159036f6ac4bef15ff1bf Mon Sep 17 00:00:00 2001 From: CyberMind-FR Date: Sat, 10 Jan 2026 15:19:08 +0100 Subject: [PATCH] fix: Use baseclass.extend() for mitmproxy API module LuCI requires modules to use baseclass.extend() pattern. Fixed "factory yields invalid constructor" error. Co-Authored-By: Claude Opus 4.5 --- .../luci-static/resources/mitmproxy/api.js | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/package/secubox/luci-app-mitmproxy/htdocs/luci-static/resources/mitmproxy/api.js b/package/secubox/luci-app-mitmproxy/htdocs/luci-static/resources/mitmproxy/api.js index 2ff19e95..769f1b77 100644 --- a/package/secubox/luci-app-mitmproxy/htdocs/luci-static/resources/mitmproxy/api.js +++ b/package/secubox/luci-app-mitmproxy/htdocs/luci-static/resources/mitmproxy/api.js @@ -1,4 +1,5 @@ 'use strict'; +'require baseclass'; 'require rpc'; var callMitmproxy = rpc.declare({ @@ -59,7 +60,7 @@ var callClearData = rpc.declare({ method: 'clear_data' }); -return { +return baseclass.extend({ getStatus: function() { return callMitmproxy().catch(function() { return { running: false, enabled: false }; @@ -117,12 +118,13 @@ return { }, getAllData: function() { + var self = this; return Promise.all([ - this.getStatus(), - this.getConfig(), - this.getStats(), - this.getTopHosts(10), - this.getCaInfo() + self.getStatus(), + self.getConfig(), + self.getStats(), + self.getTopHosts(10), + self.getCaInfo() ]).then(function(results) { return { status: results[0], @@ -148,4 +150,4 @@ return { if (num >= 1000) return (num / 1000).toFixed(1) + 'K'; return num.toString(); } -}; +});