gandalf/secubox-openwrt
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(mitmproxy): Fix JSON output corruption from grep -c exit codes

Browse Source 
grep -c returns exit code 1 when no matches found (even though it
outputs 0), causing `|| echo 0` to append an extra 0 and corrupt
the JSON response. This broke ubus calls and LuCI status display.

Use `: ${var:=0}` pattern instead to provide defaults.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
CyberMind-FR 2026-02-03 05:15:27 +01:00
parent b2f0e23c32
commit c0991336bb
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
package/secubox/luci-app-mitmproxy/root/usr/libexec/rpcd/luci.mitmproxy
View File

@ -67,7 +67,8 @@ get_status() {
local threats_log="${data_path:-/srv/mitmproxy}/threats.log"
if [ -f "$threats_log" ]; then
local today=$(date -u +%Y-%m-%d)
threats_today=$(grep -c "\"timestamp\": \"$today" "$threats_log" 2>/dev/null || echo 0)
threats_today=$(grep -c "\"timestamp\": \"$today" "$threats_log" 2>/dev/null)
: ${threats_today:=0}
fi
# Count processed autobans
@ -77,7 +78,8 @@ get_status() {
if [ -f "$autoban_log" ]; then
autobans_total=$(wc -l < "$autoban_log" 2>/dev/null || echo 0)
local today=$(date +%Y-%m-%d)
autobans_today=$(grep -c "^$today" "$autoban_log" 2>/dev/null || echo 0)
autobans_today=$(grep -c "^$today" "$autoban_log" 2>/dev/null)
: ${autobans_today:=0}
fi
# Pending autoban requests