From 8b65bd64e9d069ba8f167da07084fc2e340b53c8 Mon Sep 17 00:00:00 2001
From: CyberMind-FR <gandalf@Gk2.net>
Date: Sun, 8 Mar 2026 17:01:43 +0100
Subject: [PATCH] fix(rtty-remote): Add null checks and move to KISS UI System
 Hub

- Fix TypeError in support.js: add null checks for DOM elements
- Move menu entries from Services to System Hub (KISS UI)
- Menu paths: admin/secubox/system/system-hub/rtty-remote
- Menu paths: admin/secubox/system/system-hub/support

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---
 .../resources/view/rtty-remote/support.js         |  2 ++
 .../share/luci/menu.d/luci-app-rtty-remote.json   | 15 +++++++--------
 2 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/package/secubox/luci-app-rtty-remote/htdocs/luci-static/resources/view/rtty-remote/support.js b/package/secubox/luci-app-rtty-remote/htdocs/luci-static/resources/view/rtty-remote/support.js
index 6f0e7d22..f1eb8fa2 100644
--- a/package/secubox/luci-app-rtty-remote/htdocs/luci-static/resources/view/rtty-remote/support.js
+++ b/package/secubox/luci-app-rtty-remote/htdocs/luci-static/resources/view/rtty-remote/support.js
@@ -432,12 +432,14 @@ return view.extend({
 
     appendTerminal: function(text) {
         var output = document.getElementById('terminal-output');
+        if (!output) return;
         output.textContent += text;
         output.scrollTop = output.scrollHeight;
     },
 
     updateSessionsList: function() {
         var container = document.getElementById('active-sessions-list');
+        if (!container) return;
         container.innerHTML = '';
 
         var codes = Object.keys(supportSessions);
diff --git a/package/secubox/luci-app-rtty-remote/root/usr/share/luci/menu.d/luci-app-rtty-remote.json b/package/secubox/luci-app-rtty-remote/root/usr/share/luci/menu.d/luci-app-rtty-remote.json
index e9e44908..85dd87d1 100644
--- a/package/secubox/luci-app-rtty-remote/root/usr/share/luci/menu.d/luci-app-rtty-remote.json
+++ b/package/secubox/luci-app-rtty-remote/root/usr/share/luci/menu.d/luci-app-rtty-remote.json
@@ -1,19 +1,18 @@
 {
-    "admin/services/rtty-remote": {
-        "title": "RTTY Remote",
-        "order": 85,
+    "admin/secubox/system/system-hub/rtty-remote": {
+        "title": "Remote Control",
+        "order": 15,
         "action": {
             "type": "view",
             "path": "rtty-remote/dashboard"
         },
         "depends": {
-            "acl": ["luci-app-rtty-remote"],
-            "uci": { "rtty-remote": true }
+            "acl": ["luci-app-rtty-remote"]
         }
     },
-    "admin/services/rtty-remote/support": {
-        "title": "Support Panel",
-        "order": 10,
+    "admin/secubox/system/system-hub/support": {
+        "title": "Remote Support",
+        "order": 16,
         "action": {
             "type": "view",
             "path": "rtty-remote/support"