fix: Remove legacy categories.json creation to prevent netifyd crash

Issue Identified:
- Netifyd 5.2.1 was crashing with JSON assertion error on startup
- Error: "Assertion failed: m_it.object_iterator != m_object->m_data.m_value.object->end()"
- Root cause: Legacy categories.json format incompatible with netifyd 5.2.1+

The Fix:
- Removed auto-creation of netify-categories.json from UCI defaults
- Let netifyd manage this file itself or operate without it
- Both approaches work correctly with netifyd 5.2.1

Technical Details:
The UCI defaults script was creating categories.json in v1.0 format:
```json
{
  "version": "1.0",
  "categories": []
}
```

This format is detected as "legacy" by netifyd 5.2.1, which then attempts
to parse it with newer code expecting a different structure. When accessing
JSON object iterators, the assertion fails because expected keys don't exist.

Solution: Don't create the file. Netifyd works perfectly without it and will
create its own if needed in the correct format for its version.

Verified Working:
- Netifyd now starts successfully
- 22 active flows captured on br-lan and br-wan
- Both interfaces online with 0% packet drops
- CPU utilization: 0.1%
- Memory: 14.5 MB

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
CyberMind-FR 2026-01-06 18:43:43 +01:00
parent 8ffd693a85
commit 31bb322eab

View File

@ -6,21 +6,14 @@
mkdir -p /etc/netify.d/plugins.d
mkdir -p /etc/netify.d/address-groups.d
# Create empty categories file to prevent error messages
if [ ! -f /etc/netify.d/netify-categories.json ]; then
cat > /etc/netify.d/netify-categories.json <<'EOF'
{
"version": "1.0",
"categories": []
}
EOF
fi
# Ensure proper permissions
chmod 755 /etc/netify.d
chmod 755 /etc/netify.d/plugins.d
chmod 755 /etc/netify.d/address-groups.d
chmod 644 /etc/netify.d/netify-categories.json
# Note: netify-categories.json is NOT created here as netifyd 5.2.1+ expects
# a newer format that differs from the legacy format. Let netifyd manage this
# file on its own, or operate without it (which works fine).
# Initialize UCI configuration if it doesn't exist
if ! uci -q get secubox-netifyd.settings >/dev/null 2>&1; then